Fix skipping map and array fields that are missing in the reader schema #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #207.
Previously, the code, generated by the compiler, tried to set the hint size on the target even when the (array or map) data was actually skipped because of a field in the writer schema missing in the reader schema. The bugfix adds a parameter to the methods generating the VM code for block entry and exit that removes the hint size operation if the reader schema is nil. Jumps are adjusted accordingly as well. A new test under
test/array-removedwas added that failed previously.Thank you, @tomasfabian, for your hints!